Suggestion: Use trimcheck in epw_readin.f90

[jaemo.lihm]

Dear developers,

In the current version of EPW in QE Gitlab, Line 870-871 of epw_readin.f90 reads

Code: Select all

  tmp_dir = TRIM(outdir)
  dvscf_dir = TRIM(dvscf_dir) // '/'

These line causes problem when one sets outdir = 'temp' because '/' is not added. (outdir = 'temp/' works fine.)

In other programs of QE, one automatically adds the missing '/' using the trimcheck function. For example, PW/src/input.f90 uses the following.

Code: Select all

tmp_dir = trimcheck ( outdir )

Therefore, I suggest to use trimcheck also in the two lines of epw_readin.f90 I cited above.

Regards,
Jae-Mo Lihm
Seoul National University

[hlee]

Dear Jae-Mo Lihm:

Thank you for the suggestion.
I will note it and reflect it in the next MR.

Sincerely,

H. Lee