A minor error in pw2wan90epw.f90

Post here questions linked with issue while running the EPW code

Moderator: stiwari

Post Reply
jaemolihm
Posts: 2
Joined: Sat Jul 27, 2019 8:06 am
Affiliation:

A minor error in pw2wan90epw.f90

Post by jaemolihm »

Dear developers,

I would like to report a minor bug in pw2wan90epw.f90, related to the USPP case.

Line 1222 of pw2wan90epw.f90 in the current develop branch in GitLab says

Code: Select all

ALLOCATE ( qb(nkb, nkb, ntyp, nbt) )

However, it should be

Code: Select all

ALLOCATE ( qb(nhm, nhm, ntyp, nbt) )


This bug causes a problem in the called subroutine PW/src/transform_qq_so.f90 , and affects calculations with USPP and spin-orbit coupling.

The corresponding line in PP/src/pw2wannier90.f90 changed some time ago by the following commit: https://gitlab.com/QEF/q-e/commit/6b740520eab157de7892120d6d4d4d99f0018f94.

Sincerely,

Jae-Mo Lihm

roxana
Posts: 172
Joined: Fri Jan 22, 2016 6:48 pm
Affiliation:

Re: A minor error in pw2wan90epw.f90

Post by roxana »

Hi Jae-Mo,

Thanks for reporting this minor bug.

Best,
Roxana
Roxana Margine
Associate Professor
Department of Physics, Applied Physics and Astronomy
Binghamton University, State University of New York

sponce
Site Admin
Posts: 616
Joined: Wed Jan 13, 2016 7:25 pm
Affiliation: EPFL

Re: A minor error in pw2wan90epw.f90

Post by sponce »

Dear Jae-Mo Lihm,

Thanks for reporting.
I have made a PR:

https://gitlab.com/QEF/q-e/merge_requests/561

Best,
Samuel
Prof. Samuel Poncé
Chercheur qualifié F.R.S.-FNRS / Professeur UCLouvain
Institute of Condensed Matter and Nanosciences
UCLouvain, Belgium
Web: https://www.samuelponce.com

Post Reply